[INTEL MKL] Fix proxy info during docker builds #29560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @penpornk any feedback on this? |
penpornk
approved these changes
Jun 11, 2019
tensorflow-bot
bot
added
kokoro:force-run
penpornk
requested changes
Jun 11, 2019
|
Thanks @penpornk |
penpornk
requested changes
Jun 14, 2019
| TF_DOCKER_BUILD_ARGS+=("--build-arg HTTP_PROXY=${http_proxy}") | ||
| TF_DOCKER_BUILD_ARGS+=("--build-arg SOCKS_PROXY=${socks_proxy}") | ||
| TF_DOCKER_BUILD_ARGS+=("--build-arg NO_PROXY=${no_proxy}") | ||
| TF_DOCKER_BUILD_ARGS+=("--build-arg HTTP_PROXY=${HTTP_PROXY}") |
There was a problem hiding this comment.
Please add a comment explaining that we need the uppercase versions because the lowercase ones don't cover all the case (or something).
There was a problem hiding this comment.
Hi @penpornk to best of my knowledge I added a comment to describe why we need both set of proxies 🙂
There was a problem hiding this comment.
Thank you very much, @ashahba! :)
penpornk
approved these changes
Jun 16, 2019
| TF_DOCKER_BUILD_ARGS+=("--build-arg HTTP_PROXY=${http_proxy}") | ||
| TF_DOCKER_BUILD_ARGS+=("--build-arg SOCKS_PROXY=${socks_proxy}") | ||
| TF_DOCKER_BUILD_ARGS+=("--build-arg NO_PROXY=${no_proxy}") | ||
| TF_DOCKER_BUILD_ARGS+=("--build-arg HTTP_PROXY=${HTTP_PROXY}") |
There was a problem hiding this comment.
Thank you very much, @ashahba! :)
tensorflow-bot
bot
added
kokoro:force-run
tensorflow-copybara
pushed a commit
that referenced
this pull request
Jun 19, 2019
PiperOrigin-RevId: 253897496
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing
swiftpackage downloads to fail because for some reasonHTTP_PROXYandHTTPS_PROXYvalues were empty.